From 6cc4f11f963dddc47b5493280bb8cc9275ddb770 Mon Sep 17 00:00:00 2001
From: huangmin <2927933426@qq.com>
Date: Sat, 6 Jun 2026 16:43:21 +0800
Subject: [PATCH] =?UTF-8?q?feat(workflow):=20=E5=AE=9E=E7=8E=B0=E9=80=89?=
 =?UTF-8?q?=E4=B8=AD=E5=88=86=E7=BB=84=E6=97=B6=E5=88=9B=E5=BB=BA=E6=96=B0?=
 =?UTF-8?q?=E7=BB=84=E6=9B=BF=E6=8D=A2=E5=8E=9F=E6=9C=89=E5=88=86=E7=BB=84?=
 =?UTF-8?q?=E7=9A=84=E5=8A=9F=E8=83=BD?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

1. 新增工作流集成测试验证分组替换逻辑
2. 重构createGroup方法，支持选中分组节点时自动替换为子节点创建新组
3. 修复多选工具栏的定位逻辑，使用react-flow内置方法计算边界
4. 更新多选工具栏显示逻辑，选中分组节点时显示创建组按钮而非取消分组
5. 新增工具栏测试用例覆盖分组创建和定位场景
---
 src/components/MultiSelectToolbar.tsx         |  34 +++---
 .../__tests__/MultiSelectToolbar.test.tsx     | 105 +++++++++++++++++-
 .../workflowStore.integration.test.ts         |  34 ++++++
 src/store/workflowStore.ts                    |  31 +++++-
 4 files changed, 172 insertions(+), 32 deletions(-)

diff --git a/src/components/MultiSelectToolbar.tsx b/src/components/MultiSelectToolbar.tsx
index 1f8ab7cc..f20f4a49 100644
--- a/src/components/MultiSelectToolbar.tsx
+++ b/src/components/MultiSelectToolbar.tsx
@@ -17,13 +17,18 @@ const STACK_GAP = 20;
 export function MultiSelectToolbar() {
   const { t } = useI18n();
   const { nodes, onNodesChange, createGroup, removeNodesFromGroup } = useWorkflowStore();
-  const { getViewport } = useReactFlow();
+  const { flowToScreenPosition, getNodesBounds } = useReactFlow();
 
   const selectedNodes = useMemo(
     () => nodes.filter((node) => node.selected),
     [nodes]
   );
 
+  const hasSelectedGroupNode = useMemo(
+    () => selectedNodes.some((node) => node.type === "group"),
+    [selectedNodes]
+  );
+
   // Check if any selected nodes are in a group
   const selectedNodeGroups = useMemo(() => {
     const groupIds = new Set(selectedNodes.map((n) => n.groupId).filter(Boolean));
@@ -36,27 +41,14 @@ export function MultiSelectToolbar() {
   const toolbarPosition = useMemo(() => {
     if (selectedNodes.length < 2) return null;
 
-    const viewport = getViewport();
-
-    // Find bounding box of selected nodes
-    let minX = Infinity;
-    let minY = Infinity;
-    let maxX = -Infinity;
-
-    selectedNodes.forEach((node) => {
-      const nodeWidth = (node.style?.width as number) || node.measured?.width || 220;
-      minX = Math.min(minX, node.position.x);
-      minY = Math.min(minY, node.position.y);
-      maxX = Math.max(maxX, node.position.x + nodeWidth);
+    const bounds = getNodesBounds(selectedNodes.map((node) => node.id));
+    const topCenter = flowToScreenPosition({
+      x: bounds.x + bounds.width / 2,
+      y: bounds.y,
     });
 
-    // Convert flow coordinates to screen coordinates
-    const centerX = (minX + maxX) / 2;
-    const screenX = centerX * viewport.zoom + viewport.x;
-    const screenY = minY * viewport.zoom + viewport.y - 50; // 50px above the top
-
-    return { x: screenX, y: screenY };
-  }, [selectedNodes, getViewport]);
+    return { x: topCenter.x, y: topCenter.y - 50 };
+  }, [flowToScreenPosition, getNodesBounds, selectedNodes]);
 
   const handleStackHorizontally = () => {
     if (selectedNodes.length < 2) return;
@@ -260,7 +252,7 @@ export function MultiSelectToolbar() {
       <div className="w-px h-4 bg-neutral-600 mx-0.5" />
 
       {/* Group/Ungroup buttons */}
-      {someInGroup ? (
+      {someInGroup && !hasSelectedGroupNode ? (
         <button
           onClick={handleUngroup}
           className="p-1.5 rounded hover:bg-neutral-700 text-neutral-400 hover:text-neutral-100 transition-colors"
diff --git a/src/components/__tests__/MultiSelectToolbar.test.tsx b/src/components/__tests__/MultiSelectToolbar.test.tsx
index f14273c0..1c2d4fa7 100644
--- a/src/components/__tests__/MultiSelectToolbar.test.tsx
+++ b/src/components/__tests__/MultiSelectToolbar.test.tsx
@@ -27,14 +27,44 @@ vi.mock("@/store/workflowStore", () => ({
 }));
 
 // Mock useReactFlow
-const mockGetViewport = vi.fn(() => ({ x: 0, y: 0, zoom: 1 }));
+const mockFlowToScreenPosition = vi.fn(({ x, y }: { x: number; y: number }) => ({ x, y }));
+const mockGetNodesBounds = vi.fn((nodeIds: string[]) => {
+  const state = mockUseWorkflowStore((s: any) => s) as { nodes: ReturnType<typeof createMockNode>[] };
+  const selectedNodes = state.nodes.filter((node) => nodeIds.includes(node.id));
+  const nodeById = new Map(state.nodes.map((node) => [node.id, node]));
+  const getAbsolutePosition = (node: ReturnType<typeof createMockNode>): { x: number; y: number } => {
+    if (!node.parentId) return node.position;
+    const parent = nodeById.get(node.parentId);
+    const parentPosition = parent ? getAbsolutePosition(parent) : { x: 0, y: 0 };
+    return {
+      x: parentPosition.x + node.position.x,
+      y: parentPosition.y + node.position.y,
+    };
+  };
+
+  const boxes = selectedNodes.map((node) => {
+    const position = getAbsolutePosition(node);
+    return {
+      x: position.x,
+      y: position.y,
+      width: (node.style?.width as number) || node.measured?.width || 220,
+      height: (node.style?.height as number) || node.measured?.height || 200,
+    };
+  });
+  const minX = Math.min(...boxes.map((box) => box.x));
+  const minY = Math.min(...boxes.map((box) => box.y));
+  const maxX = Math.max(...boxes.map((box) => box.x + box.width));
+  const maxY = Math.max(...boxes.map((box) => box.y + box.height));
+  return { x: minX, y: minY, width: maxX - minX, height: maxY - minY };
+});
 
 vi.mock("@xyflow/react", async () => {
   const actual = await vi.importActual("@xyflow/react");
   return {
     ...actual,
     useReactFlow: () => ({
-      getViewport: mockGetViewport,
+      flowToScreenPosition: mockFlowToScreenPosition,
+      getNodesBounds: mockGetNodesBounds,
     }),
   };
 });
@@ -67,6 +97,7 @@ const createDefaultState = (overrides = {}) => ({
 describe("MultiSelectToolbar", () => {
   beforeEach(() => {
     vi.clearAllMocks();
+    mockFlowToScreenPosition.mockImplementation(({ x, y }: { x: number; y: number }) => ({ x, y }));
     // Default mock implementation - no nodes selected
     mockUseWorkflowStore.mockImplementation((selector) => {
       return selector(createDefaultState());
@@ -380,6 +411,34 @@ describe("MultiSelectToolbar", () => {
       expect(mockCreateGroup).toHaveBeenCalledWith(["node-1", "node-2"]);
     });
 
+    it("should show create group button when a selected group is included", () => {
+      mockUseWorkflowStore.mockImplementation((selector) => {
+        return selector(createDefaultState({
+          nodes: [
+            createMockNode("group-node-group-1", {
+              type: "group",
+              position: { x: 0, y: 0 },
+              data: { groupId: "group-1" },
+              measured: { width: 520, height: 240 },
+            }),
+            createMockNode("node-3", { position: { x: 700, y: 0 } }),
+          ],
+        }));
+      });
+
+      render(
+        <TestWrapper>
+          <MultiSelectToolbar />
+        </TestWrapper>
+      );
+
+      const createGroupButton = screen.getByTitle("Create group");
+      fireEvent.click(createGroupButton);
+
+      expect(screen.queryByTitle("Remove from group")).not.toBeInTheDocument();
+      expect(mockCreateGroup).toHaveBeenCalledWith(["group-node-group-1", "node-3"]);
+    });
+
     it("should show ungroup button when selected nodes are in a group", () => {
       mockUseWorkflowStore.mockImplementation((selector) => {
         return selector(createDefaultState({
@@ -513,9 +572,8 @@ describe("MultiSelectToolbar", () => {
       expect(toolbar).toHaveStyle({ transform: "translateX(-50%)" });
     });
 
-    it("should account for viewport zoom in positioning", () => {
-      mockGetViewport.mockReturnValue({ x: 100, y: 50, zoom: 2 });
-
+    it("should position toolbar from React Flow screen coordinates", () => {
+      mockFlowToScreenPosition.mockReturnValue({ x: 520, y: 180 });
       mockUseWorkflowStore.mockImplementation((selector) => {
         return selector(createDefaultState({
           nodes: [
@@ -532,7 +590,42 @@ describe("MultiSelectToolbar", () => {
       );
 
       const toolbar = container.firstChild as HTMLElement;
-      expect(toolbar).toBeInTheDocument();
+      expect(mockFlowToScreenPosition).toHaveBeenCalledWith({ x: 210, y: 0 });
+      expect(toolbar).toHaveStyle({ left: "520px", top: "130px" });
+    });
+
+    it("should use absolute bounds for nodes inside groups", () => {
+      mockUseWorkflowStore.mockImplementation((selector) => {
+        return selector(createDefaultState({
+          nodes: [
+            createMockNode("group-node-group-1", {
+              type: "group",
+              position: { x: 500, y: 300 },
+              data: { groupId: "group-1" },
+              selected: false,
+              measured: { width: 520, height: 260 },
+            }),
+            createMockNode("node-1", {
+              position: { x: 20, y: 30 },
+              parentId: "group-node-group-1",
+              groupId: "group-1",
+            }),
+            createMockNode("node-2", {
+              position: { x: 260, y: 40 },
+              parentId: "group-node-group-1",
+              groupId: "group-1",
+            }),
+          ],
+        }));
+      });
+
+      render(
+        <TestWrapper>
+          <MultiSelectToolbar />
+        </TestWrapper>
+      );
+
+      expect(mockFlowToScreenPosition).toHaveBeenCalledWith({ x: 750, y: 330 });
     });
   });
 });
diff --git a/src/store/__tests__/workflowStore.integration.test.ts b/src/store/__tests__/workflowStore.integration.test.ts
index 2bc96644..a310a3af 100644
--- a/src/store/__tests__/workflowStore.integration.test.ts
+++ b/src/store/__tests__/workflowStore.integration.test.ts
@@ -2801,6 +2801,40 @@ describe("workflowStore integration tests", () => {
         expect(group.size.width).toBeGreaterThanOrEqual(300);
         expect(group.size.height).toBeGreaterThanOrEqual(200);
       });
+
+      it("should replace selected existing groups when creating a new group", () => {
+        useWorkflowStore.setState({
+          nodes: [
+            createTestNode("prompt-1", "prompt", { prompt: "one" }, { x: 0, y: 0 }),
+            createTestNode("prompt-2", "prompt", { prompt: "two" }, { x: 300, y: 0 }),
+            createTestNode("prompt-3", "prompt", { prompt: "three" }, { x: 700, y: 0 }),
+          ],
+          edges: [],
+          groups: {},
+        });
+
+        let store = useWorkflowStore.getState();
+        const firstGroupId = store.createGroup(["prompt-1", "prompt-2"]);
+        store = useWorkflowStore.getState();
+        const firstGroupNodeId = `group-node-${firstGroupId}`;
+
+        const secondGroupId = store.createGroup([firstGroupNodeId, "prompt-3"]);
+        store = useWorkflowStore.getState();
+
+        expect(secondGroupId).toBeTruthy();
+        expect(store.groups[firstGroupId]).toBeUndefined();
+        expect(store.groups[secondGroupId]).toBeDefined();
+        expect(store.nodes.some((node) => node.id === firstGroupNodeId)).toBe(false);
+
+        const regroupedNodes = store.nodes.filter((node) =>
+          ["prompt-1", "prompt-2", "prompt-3"].includes(node.id)
+        );
+        expect(regroupedNodes).toHaveLength(3);
+        regroupedNodes.forEach((node) => {
+          expect(node.groupId).toBe(secondGroupId);
+          expect(node.parentId).toBe(`group-node-${secondGroupId}`);
+        });
+      });
     });
 
     describe("addNodesToGroup with non-standard node types", () => {
diff --git a/src/store/workflowStore.ts b/src/store/workflowStore.ts
index 91cb992e..92a56be9 100644
--- a/src/store/workflowStore.ts
+++ b/src/store/workflowStore.ts
@@ -1653,18 +1653,33 @@ const workflowStoreImpl: StateCreator<WorkflowStore> = (set, get) => ({
 
     if (nodeIds.length === 0) return "";
 
-    // Get the nodes to group
-    const nodesToGroup = nodes.filter((n) => nodeIds.includes(n.id) && n.type !== "group");
+    const selectedIdSet = new Set(nodeIds);
+    const selectedGroupIds = new Set(
+      nodes
+        .filter((node) => node.type === "group" && selectedIdSet.has(node.id))
+        .map((node) => (node.data as { groupId?: string }).groupId)
+        .filter((groupId): groupId is string => Boolean(groupId && groups[groupId]))
+    );
+
+    // Get the nodes to group. If a group node is selected, replace that group with
+    // its child nodes so the new group becomes the only wrapper.
+    const nodesToGroup = nodes.filter(
+      (node) =>
+        node.type !== "group" &&
+        (selectedIdSet.has(node.id) || Boolean(node.groupId && selectedGroupIds.has(node.groupId)))
+    );
     if (nodesToGroup.length === 0) return "";
     pushUndoCheckpoint(get, set);
 
     // Calculate bounding box of selected nodes
     const nodeById = new Map(nodes.map((node) => [node.id, node]));
+    const absolutePositionByNodeId = new Map<string, XYPosition>();
     let minX = Infinity, minY = Infinity, maxX = -Infinity, maxY = -Infinity;
     nodesToGroup.forEach((node) => {
       // Use measured dimensions (actual rendered size) first, then style, then type-specific defaults
       const { width, height } = getNodeSize(node);
       const absolutePosition = getAbsoluteNodePosition(node, nodeById);
+      absolutePositionByNodeId.set(node.id, absolutePosition);
 
       minX = Math.min(minX, absolutePosition.x);
       minY = Math.min(minY, absolutePosition.y);
@@ -1706,13 +1721,14 @@ const workflowStoreImpl: StateCreator<WorkflowStore> = (set, get) => ({
 
     const groupNode = createGroupNode(newGroup);
     const selectedIds = new Set(nodesToGroup.map((node) => node.id));
+    const selectedGroupNodeIds = new Set([...selectedGroupIds].map((groupId) => getGroupNodeId(groupId)));
 
     set((state) => ({
       nodes: [
         groupNode,
-        ...state.nodes.map((node) => {
+        ...state.nodes.filter((node) => !selectedGroupNodeIds.has(node.id)).map((node) => {
           if (!selectedIds.has(node.id)) return node;
-          const absolutePosition = getAbsoluteNodePosition(node, nodeById);
+          const absolutePosition = absolutePositionByNodeId.get(node.id) ?? getAbsoluteNodePosition(node, nodeById);
           return {
             ...node,
             parentId: groupNode.id,
@@ -1727,7 +1743,12 @@ const workflowStoreImpl: StateCreator<WorkflowStore> = (set, get) => ({
           } as WorkflowNode;
         }),
       ],
-      groups: { ...state.groups, [id]: newGroup },
+      groups: {
+        ...Object.fromEntries(
+          Object.entries(state.groups).filter(([groupId]) => !selectedGroupIds.has(groupId))
+        ),
+        [id]: newGroup,
+      },
       hasUnsavedChanges: true,
     }));