From 7cb42aa0aa3024da79bc893ec16eba7fb4f29be8 Mon Sep 17 00:00:00 2001
From: shrimbly <falloon.willie@gmail.com>
Date: Tue, 24 Feb 2026 13:08:30 +1300
Subject: [PATCH] fix(perf): guard ArrayNode height check and fix variable
 shadowing

- Add early return in setNodes when height unchanged to prevent unnecessary updates
- Rename shadowed 'selected' variable to 'currentSelection' in validation useEffect
- Reduces redundant React Flow re-renders when array items don't change height
---
 src/components/nodes/ArrayNode.tsx | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/components/nodes/ArrayNode.tsx b/src/components/nodes/ArrayNode.tsx
index 8f591fa2..a01052b3 100644
--- a/src/components/nodes/ArrayNode.tsx
+++ b/src/components/nodes/ArrayNode.tsx
@@ -150,8 +150,8 @@ export function ArrayNode({ id, data, selected }: NodeProps<ArrayNodeType>) {
 
   // Reset selection if it no longer points to a valid parsed item.
   useEffect(() => {
-    const selected = nodeData.selectedOutputIndex;
-    if (selected !== null && (selected < 0 || selected >= previewItems.length)) {
+    const currentSelection = nodeData.selectedOutputIndex;
+    if (currentSelection !== null && (currentSelection < 0 || currentSelection >= previewItems.length)) {
       updateNodeData(id, { selectedOutputIndex: null });
     }
   }, [id, nodeData.selectedOutputIndex, previewItems.length, updateNodeData]);
@@ -163,9 +163,11 @@ export function ArrayNode({ id, data, selected }: NodeProps<ArrayNodeType>) {
     const newHeight = Math.max(baseHeight, 270 + previewItems.length * perItemHeight);
 
     setNodes((nodes) =>
-      nodes.map((node) =>
-        node.id === id ? { ...node, style: { ...node.style, height: newHeight } } : node
-      )
+      nodes.map((node) => {
+        if (node.id !== id) return node;
+        if ((node.style?.height as number) === newHeight) return node;
+        return { ...node, style: { ...node.style, height: newHeight } };
+      })
     );
   }, [id, previewItems.length, setNodes]);