From a69114cfe223d0f1797f6cc94caa092d61d17c70 Mon Sep 17 00:00:00 2001 From: shrimbly Date: Wed, 11 Mar 2026 08:48:43 +1300 Subject: [PATCH] fix: rename shadowed `selected` to `selectedNodes` in edge selectors The `selected` variable inside the Zustand selector shadowed the `selected` prop from React Flow's EdgeProps, which could cause confusion during maintenance. Co-Authored-By: Claude Opus 4.6 --- src/components/edges/EditableEdge.tsx | 6 +++--- src/components/edges/ReferenceEdge.tsx | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/components/edges/EditableEdge.tsx b/src/components/edges/EditableEdge.tsx index d93ad92f..32e57291 100644 --- a/src/components/edges/EditableEdge.tsx +++ b/src/components/edges/EditableEdge.tsx @@ -48,9 +48,9 @@ export function EditableEdge({ // Narrow selector: returns boolean, only re-renders when selection relevance changes const isConnectedToSelection = useWorkflowStore((state) => { - const selected = state.nodes.filter((n) => n.selected); - if (selected.length === 0) return false; - return selected.some((n) => n.id === source || n.id === target); + const selectedNodes = state.nodes.filter((n) => n.selected); + if (selectedNodes.length === 0) return false; + return selectedNodes.some((n) => n.id === source || n.id === target); }); const edgeData = data as EdgeData | undefined; diff --git a/src/components/edges/ReferenceEdge.tsx b/src/components/edges/ReferenceEdge.tsx index 225002da..9829f887 100644 --- a/src/components/edges/ReferenceEdge.tsx +++ b/src/components/edges/ReferenceEdge.tsx @@ -24,9 +24,9 @@ export function ReferenceEdge({ }: EdgeProps) { // Narrow selector: returns boolean, only re-renders when selection relevance changes const isConnectedToSelection = useWorkflowStore((state) => { - const selected = state.nodes.filter((n) => n.selected); - if (selected.length === 0) return false; - return selected.some((n) => n.id === source || n.id === target); + const selectedNodes = state.nodes.filter((n) => n.selected); + if (selectedNodes.length === 0) return false; + return selectedNodes.some((n) => n.id === source || n.id === target); }); // Calculate the path - always use curved for reference edges for softer look