Browse Source

fix: rename shadowed `selected` to `selectedNodes` in edge selectors

The `selected` variable inside the Zustand selector shadowed the
`selected` prop from React Flow's EdgeProps, which could cause
confusion during maintenance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
handoff-20260429-1057
shrimbly 4 months ago
parent
commit
a69114cfe2
  1. 6
      src/components/edges/EditableEdge.tsx
  2. 6
      src/components/edges/ReferenceEdge.tsx

6
src/components/edges/EditableEdge.tsx

@ -48,9 +48,9 @@ export function EditableEdge({
// Narrow selector: returns boolean, only re-renders when selection relevance changes
const isConnectedToSelection = useWorkflowStore((state) => {
const selected = state.nodes.filter((n) => n.selected);
if (selected.length === 0) return false;
return selected.some((n) => n.id === source || n.id === target);
const selectedNodes = state.nodes.filter((n) => n.selected);
if (selectedNodes.length === 0) return false;
return selectedNodes.some((n) => n.id === source || n.id === target);
});
const edgeData = data as EdgeData | undefined;

6
src/components/edges/ReferenceEdge.tsx

@ -24,9 +24,9 @@ export function ReferenceEdge({
}: EdgeProps) {
// Narrow selector: returns boolean, only re-renders when selection relevance changes
const isConnectedToSelection = useWorkflowStore((state) => {
const selected = state.nodes.filter((n) => n.selected);
if (selected.length === 0) return false;
return selected.some((n) => n.id === source || n.id === target);
const selectedNodes = state.nodes.filter((n) => n.selected);
if (selectedNodes.length === 0) return false;
return selectedNodes.some((n) => n.id === source || n.id === target);
});
// Calculate the path - always use curved for reference edges for softer look

Loading…
Cancel
Save